Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.10 backport] Deprecate Kubernetes stack support #3174

Merged
merged 3 commits into from
Jul 28, 2021
Merged

[20.10 backport] Deprecate Kubernetes stack support #3174

merged 3 commits into from
Jul 28, 2021

Conversation

thaJeztah
Copy link
Member

backport of #3166 and #3167

@mat007 @thaJeztah
Deprecate Kubernetes stack support
b639ea8 
Signed-off-by: Mathieu Champlon <mathieu.champlon@docker.com>
(cherry picked from commit 7190255)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@mat007 @thaJeztah
Deprecate Kubernetes stack support
0793f96 
Signed-off-by: Mathieu Champlon <mathieu.champlon@docker.com>
(cherry picked from commit c05f0f5)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@mat007 @thaJeztah
Deprecate Kubernetes context support
1d37fb3 
Signed-off-by: Mathieu Champlon <mathieu.champlon@docker.com>
(cherry picked from commit a033cdf)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah added this to the 20.10.8 milestone Jul 2, 2021
@thaJeztah
Copy link
Member Author

Oh! CI is broken in the 20.10 branch;


=== FAIL: e2e/image TestTrustedBuild (1.77s)
    build_test.go:76: assertion failed: 
        Command:  docker build -t myimage .
        ExitCode: 1
        Error:    exit status 1
        Stdout:   Sending build context to Docker daemon  2.048kB

        Step 1/4 : FROM registry:5000/trust-build1@sha256:641b95ddb2ea9dc2af1a0113b6b348ebc20872ba615204fbe12148e98fd6f23d as build-base
        sha256:641b95ddb2ea9dc2af1a0113b6b348ebc20872ba615204fbe12148e98fd6f23d: Pulling from trust-build1
        Digest: sha256:641b95ddb2ea9dc2af1a0113b6b348ebc20872ba615204fbe12148e98fd6f23d
        Status: Downloaded newer image for registry:5000/trust-build1@sha256:641b95ddb2ea9dc2af1a0113b6b348ebc20872ba615204fbe12148e98fd6f23d
         ---> 76da55c8019d
        Step 2/4 : RUN echo ok > /foo
         ---> Running in d0e4a2d49351
        
        Stderr:   cgroups: cgroup mountpoint does not exist: unknown
        
        
        Failures:
        ExitCode was 1 expected 0
        Expected stderr to contain "Tagging registry:5000/trust-build1@sha"
        Expected no error

Need to backport #3137

This was referenced Jul 2, 2021
Merged
Merged
@thaJeztah
Copy link
Member Author

Opened #3176 to fix CI

@codecov-commenter
Copy link

Codecov Report

Merging #3174 (1d37fb3) into 20.10 (063e3dd) will decrease coverage by 0.01%.
The diff coverage is 21.42%.

@@            Coverage Diff             @@
##            20.10    #3174      +/-   ##
==========================================
- Coverage   57.06%   57.04%   -0.02%     
==========================================
  Files         299      299              
  Lines       18691    18705      +14     
==========================================
+ Hits        10666    10671       +5     
- Misses       7157     7167      +10     
+ Partials      868      867       -1

@thaJeztah
Copy link
Member Author

OK, CI is green again now 👍

mat007
mat007 approved these changes Jul 2, 2021
View reviewed changes
Copy link
Member

@mat007 mat007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

StefanScherer
StefanScherer approved these changes Jul 5, 2021
View reviewed changes
Copy link
Member

@StefanScherer StefanScherer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit f9d091f into docker:20.10 Jul 28, 2021
@thaJeztah thaJeztah deleted the 20.10_backport_deprecate_kube branch July 28, 2021 13:47
@thaJeztah thaJeztah mentioned this pull request Jun 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mat007 mat007 mat007 approved these changes

@StefanScherer StefanScherer StefanScherer approved these changes

@silvin-lubecki silvin-lubecki Awaiting requested review from silvin-lubecki silvin-lubecki is a code owner

Assignees
No one assigned
Labels
area/context area/kubernetes impact/changelog impact/deprecation status/2-code-review
Projects
None yet
Milestone
20.10.8
Development

Successfully merging this pull request may close these issues.
4 participants
@thaJeztah @codecov-commenter @StefanScherer @mat007